Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #7992: Add CloudControllerConfigArgv template function, Expose #8166

Conversation

DavidSie
Copy link
Contributor

Cherry pick of #7992 on release-1.17.

#7992: Add CloudControllerConfigArgv template function, Expose

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot
Copy link
Contributor

Hi @DavidSie. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 20, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 20, 2019
@geojaz
Copy link
Member

geojaz commented Dec 22, 2019

/needs-ok-to-test
but looks like it needs some other attention as well

@DavidSie DavidSie force-pushed the automated-cherry-pick-of-#7992-origin-release-1.17 branch from 68bd49e to bd97e6b Compare December 23, 2019 15:24
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 8, 2020
@DavidSie DavidSie force-pushed the automated-cherry-pick-of-#7992-origin-release-1.17 branch 2 times, most recently from b0097b9 to 24e51f6 Compare January 8, 2020 15:56
@DavidSie DavidSie force-pushed the automated-cherry-pick-of-#7992-origin-release-1.17 branch from 24e51f6 to 9fe36ad Compare January 8, 2020 20:12
@DavidSie
Copy link
Contributor Author

DavidSie commented Jan 8, 2020

@geojaz please take a look. Also please take a look at this pr: #8077 since they are both adding the same feature to existing releases.

@DavidSie
Copy link
Contributor Author

DavidSie commented Jan 9, 2020

@zetaab pls take a look.

@johngmyers
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 11, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 11, 2020
@johngmyers
Copy link
Member

/retest

@DavidSie
Copy link
Contributor Author

@geojaz imho it can be merged.

Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidSie, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 33a14f7 into kubernetes:release-1.17 Jan 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants