-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #7992: Add CloudControllerConfigArgv template function, Expose #8166
Automated cherry pick of #7992: Add CloudControllerConfigArgv template function, Expose #8166
Conversation
Hi @DavidSie. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/needs-ok-to-test |
68bd49e
to
bd97e6b
Compare
…erConfigArgv function to templates, and testing it. Exposing CloudControllerConfigArgv function to templates, and testing it.
b0097b9
to
24e51f6
Compare
24e51f6
to
9fe36ad
Compare
@zetaab pls take a look. |
/ok-to-test |
/retest |
@geojaz imho it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DavidSie, zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #7992 on release-1.17.
#7992: Add CloudControllerConfigArgv template function, Expose
For details on the cherry pick process, see the cherry pick requests page.