-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(openstack): fix additional security groups on instance groups #8004
fix(openstack): fix additional security groups on instance groups #8004
Conversation
Previously we mistakenly used the names of the additional security groups where the API is expecting their ID.
Hi @mitch000001. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
Thanks for fixing it!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mitch000001, zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…004-origin-release-1.15 Automated cherry pick of #8004 origin release 1.15: fix(openstack): fix additional security groups on instance groups
…004-origin-release-1.16 Automated cherry pick of #8004: fix(openstack): fix additional security groups on instance groups
Previously we mistakenly used the names of the additional security
groups where the Openstack API is expecting their IDs.