Template the calico flex volume based on the kubelet spec

[mtl-wgtwo]

The calico spec uses a flex dir that doesn't work on CoreOS
and probably other platforms. This PR templates the spec
dir with the value from the kubelet spec that is set here:

https://github.com/kubernetes/kops/blob/master/docs/cluster_spec.md#configure-a-flex-volume-plugin-directory

Note that without this, kops 1.15 fails to provision on CoreOS nodes.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @mtl-wgtwo!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @mtl-wgtwo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mikesplain]

Thanks for the contribution @mtl-wgtwo, we're sorry for the issue! Would you mind signing the CLA with the email used to commit your code? Once you do this, you'll be able to contribute to all our projects going forward.

Once that is complete, we can kick off tests and get this rolling into a fix! Thanks so much!

[mazzy89]

I think this PR makes the CoreOS/Flatcar support happening faster than my PR #7545 which is left behind since a while.

Since seems that this is getting the right attraction so I would refactor my PR and keep the only few things missing for the complete Flatcar support and rely on this to customize the Calico Flex volume plugins.

[mazzy89]

@mtl-wgtwo keep in mind please that also the controller-manager set as a flag the volume plugin dir. I'm not sure if we change it in kubelet, we need to change it also in here https://github.com/kubernetes/kops/blob/master/nodeup/pkg/model/kube_controller_manager.go#L167 WDYT?

[mazzy89]

I've checked better the code and I've found out that setting the kubelet volume plugin dir in the spec, it sets it in the controller manager too. So all good here.

[mtl-wgtwo]

/assign @KashifSaadat

[mtl-wgtwo]

Thanks for the feedback @mazzy89 and @mikesplain. I’m currently working in my company to get the CLA sorted out. It will be a one-time pain and I’ll get this moving as quickly as possible.

[mazzy89]

@mtl-wgtwo which is the status here? May I help somehow? Perhaps moving this change into my already opened PR would help to move faster and have CoreOS/Flatcar support fixed for the kops 1.15.x release. Let me know if is fine for you.

[zetaab]

/approve
/lgtm

[zetaab]

ah missing CLA, its not going through

[zetaab]

/ok-to-test

/approve cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtl-wgtwo
To complete the pull request process, please assign kashifsaadat
You can assign the PR to them by writing /assign @kashifsaadat in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mazzy89]

thank yoo @zetaab for the approval here. however we don't have CLA here so we can't go through it. Can you also please take a look to my PR #7545 which would help to fix the Flatcar support and together with this PR have everything working?

[k8s-ci-robot]

@mtl-wgtwo: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kops-verify-packages	736a379	link	/test pull-kops-verify-packages

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[hakman]

This was included as part of #8062.

[k8s-ci-robot]

@mtl-wgtwo: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mazzy89]

Niceee :-) so this can be closed

[mtl-wgtwo]

Apologies on being slow on this. We've signed the CCLA, but for some reason it isn't registering properly so I can't sign my CLA. I'll just close this then and deal with the other issue later.