Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix goimports errors #7955

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Fix goimports errors #7955

merged 1 commit into from
Nov 19, 2019

Conversation

rifelpet
Copy link
Member

It turns out we werent running verify-goimports in our CI jobs.

While we work to get that enabled in #7952, we can at least unblock the releases by doing a one-time fix of the failing goimports

@rifelpet
Fix goimports errors
3dc06af 
It turns out we werent running verify-goimports in our CI jobs.

While we work to get that enabled, we can at least unblock the releases by doing a one-time fix of the failing goimports
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 19, 2019
@rifelpet
Copy link
Member Author 

FAIL: 'goimports -w' needs to be run on the following files:
k8s.io/kops/cmd/kops/rollingupdatecluster.go
k8s.io/kops/pkg/instancegroups/rollingupdate.go
k8s.io/kops/pkg/instancegroups/rollingupdate_test.go

FAIL: Please run the following command: make goimports
make: *** [verify-goimports] Error 1

@granular-ryanbonham
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2019
mikesplain
mikesplain approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks so much!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1ac198e into kubernetes:master Nov 19, 2019
@rifelpet rifelpet deleted the fix-goimports branch August 6, 2020 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesplain mikesplain mikesplain approved these changes

@robinpercy robinpercy Awaiting requested review from robinpercy

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@mikesplain mikesplain

@granular-ryanbonham granular-ryanbonham

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rifelpet @granular-ryanbonham @k8s-ci-robot @mikesplain