-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct values for CALICO_IPV4POOL_IPIP in Calico v3 #7899
Use correct values for CALICO_IPV4POOL_IPIP in Calico v3 #7899
Conversation
Because the accepted values have changed since v3.0: https://docs.projectcalico.org/v3.0/reference/node/configuration#environment-variables
Because the accepted values have changed since v3.0: https://docs.projectcalico.org/v3.0/reference/node/configuration#environment-variables
Hi @zacblazic. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
Thanks - a great thing to get into 1.17, and I don't think we need to backport as it is backwards compatible. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, zacblazic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updates the Calico v3 manifests to use more correct values for the
CALICO_IPV4POOL_IPIP
environment variable, which appear to have changed since v3.0.0.Previous values are still backwards-compatible currently.