Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing priorityClassName to flannel DaemonSet #7842

Merged
merged 2 commits into from
Nov 11, 2019
Merged

add missing priorityClassName to flannel DaemonSet #7842

merged 2 commits into from
Nov 11, 2019

Conversation

EladDolev
Copy link
Contributor

Without priorityClassName there is a possibility that flannel pod won't be scheduled to a node, or even worse, be preempted

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 29, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @EladDolev!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @EladDolev. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2019
@EladDolev EladDolev force-pushed the flannel_priorityclass branch from 1689458 to 09fc09f Compare October 29, 2019 10:10
@EladDolev
Copy link
Contributor Author

CLA is signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 29, 2019
@rifelpet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2019
@EladDolev
Copy link
Contributor Author

/retest

@EladDolev EladDolev force-pushed the flannel_priorityclass branch from 44c8b19 to 16da5f1 Compare October 30, 2019 15:26
@EladDolev
Copy link
Contributor Author

/test pull-kops-e2e-kubernetes-aws

6 similar comments
@EladDolev
Copy link
Contributor Author

/test pull-kops-e2e-kubernetes-aws

@EladDolev
Copy link
Contributor Author

/test pull-kops-e2e-kubernetes-aws

@EladDolev
Copy link
Contributor Author

/test pull-kops-e2e-kubernetes-aws

@EladDolev
Copy link
Contributor Author

/test pull-kops-e2e-kubernetes-aws

@EladDolev
Copy link
Contributor Author

/test pull-kops-e2e-kubernetes-aws

@EladDolev
Copy link
Contributor Author

/test pull-kops-e2e-kubernetes-aws

@rifelpet
Copy link
Member

rifelpet commented Nov 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2019
@EladDolev
Copy link
Contributor Author

/assign @chrislovecnm

@shamil
Copy link
Contributor

shamil commented Nov 7, 2019

@rifelpet can you approve?

@rifelpet
Copy link
Member

rifelpet commented Nov 8, 2019

I cant approve, only approvers listed in the OWNERS file can approve.

KashifSaadat
KashifSaadat approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@KashifSaadat KashifSaadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EladDolev thank you for the contribution!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EladDolev, KashifSaadat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2019
@EladDolev
Copy link
Contributor Author

@EladDolev thank you for the contribution!

/lgtm
/approve

Thank you so much
Are we expected to see this any time soon in any of the existing releases ?

@k8s-ci-robot k8s-ci-robot merged commit 40e2ef3 into kubernetes:master Nov 11, 2019
@KashifSaadat
Copy link
Contributor

No worries! I've created a cherry-pick #7913 to get it into the next v1.15 release, otherwise it will be included in the releases for kops v1.16 onwards.

@EladDolev
Copy link
Contributor Author

No worries! I've created a cherry-pick #7913 to get it into the next v1.15 release, otherwise it will be included in the releases for kops v1.16 onwards.

Amazing ! ;-)

k8s-ci-robot added a commit that referenced this pull request Nov 11, 2019
@k8s-ci-robot
Merge pull request #7913 from appvia/automated-cherry-pick-of-#7842-u…
20f7d4c 
…pstream-release-1.15

Automated cherry pick of #7842: Add missing priorityClassName to flannel DaemonSet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KashifSaadat KashifSaadat KashifSaadat approved these changes

@robinpercy robinpercy Awaiting requested review from robinpercy

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@chrislovecnm chrislovecnm

@rifelpet rifelpet

@KashifSaadat KashifSaadat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@EladDolev @k8s-ci-robot @rifelpet @shamil @KashifSaadat @chrislovecnm