-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document eventTTL #7826
Document eventTTL #7826
Conversation
Hi @tioxy. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @geojaz |
/assign |
Hi @tioxy thanks for the PR! I didn't even know this flag exists, thanks for documenting it! We actually just pushed a new docs site via netlify, which includes a number of changes that are required for netlify tests to pass. Would you mind rebasing off master with the latest changes? Should be as simple as:
Thanks so much! Looking forward to getting this in! /ok-to-test |
Add and example and explain that you should fill empty units of time with zeros.
ff8826b
to
173085e
Compare
Hi @mikesplain Just rebased with the upstream, seems fine now. Thanks! |
No worries! Looks good! Thanks again! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikesplain, tioxy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Documents
eventTTL
usage explaining that you must fill empty units of time with zeros.Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
This configuration from ClusterSpec is already inside the release 1.15, but lacks documentation on how to use it.
This flag was added here: #7487
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: