Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: comment out shallow_since as fails to build with bazel 1.0 #7771

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

justinsb
Copy link
Member

Gives an error:

error running 'git reset --hard f905a6636c5106c36cc979bdcc19f0fe4fc01ede' while working with @distroless:
fatal: Could not parse object 'f905a6636c5106c36cc979bdcc19f0fe4fc01ede'.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2019
@rifelpet
Copy link
Member

looks like you cant use @distroless in a commit message :(

Gives an error:

error running 'git reset --hard f905a6636c5106c36cc979bdcc19f0fe4fc01ede' while working with distroless:
fatal: Could not parse object 'f905a6636c5106c36cc979bdcc19f0fe4fc01ede'.
@justinsb justinsb force-pushed the bazel_shallow_since_broken branch from c03f340 to 2884f02 Compare October 11, 2019 14:33
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 11, 2019
@rifelpet
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit f6fd38c into kubernetes:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants