Update etcd-manager with OpenStack fixes #7710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
etcd-manager changes: * Use disk by id for mounting devices in OpenStack [zetaab](https://github.com/zetaab) [kubernetes#253](kopeio/etcd-manager#253)
k8s-ci-robot
added
the
size/S
justinsb
force-pushed
the
update_etcd_manager
branch
from
a677ecd to
e1be7ae
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
This is the PR you wanted in 1.14, right @zetaab ? Any other blockers for 1.14 from your point of view - I think it's good to go otherwise! |
|
/lgtm Yeah, we need this 1.15 and master too :) Thanks! |
k8s-ci-robot
added
the
lgtm
This was referenced Sep 30, 2019
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 30, 2019
Cherry pick of #7710 onto release-1.14
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 30, 2019
Cherry pick of #7710 onto release-1.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
etcd-manager changes: