Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix spelling mistakes #7709

Merged
merged 1 commit into from
Oct 1, 2019
Merged

docs: fix spelling mistakes #7709

merged 1 commit into from
Oct 1, 2019

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented Sep 30, 2019

No description provided.

@k8s-ci-robot
Copy link
Contributor

Welcome @hwdef!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 30, 2019
@hwdef
Copy link
Member Author

hwdef commented Sep 30, 2019

/assign @gambol99

@hwdef
Copy link
Member Author

hwdef commented Sep 30, 2019

/assign @gambol99

bittopaz
bittopaz reviewed Sep 30, 2019
View reviewed changes
docs/apireference/build/documents/_generated_cluster_v1alpha2_kops_concept.md Outdated
@@ -113,7 +113,7 @@ Appears In:

Field | Description
------------ | -----------
additionalNetworkCIDRs <br /> *string array* | AdditionalNetworkCIDRs is a list of aditional CIDR used for the AWS VPC or otherwise allocated to k8s. This is a real CIDR, not the internal k8s network On AWS, it maps to any aditional CIDRs added to a VPC.
additionalNetworkCIDRs <br /> *string array* | AdditionalNetworkCIDRs is a list ofadditional CIDR used for the AWS VPC or otherwise allocated to k8s. This is a real CIDR, not the internal k8s network On AWS, it maps to anyadditional CIDRs added to a VPC.
Copy link
Contributor

@bittopaz bittopaz Sep 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you missed space between the words.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes,it is my mistake.
I fixed it.

bittopaz
bittopaz reviewed Sep 30, 2019
View reviewed changes
docs/apireference/build/documents/_generated_instancegroup_v1alpha2_kops_concept.md Outdated
@@ -77,7 +77,7 @@ Appears In:
Field | Description
------------ | -----------
additionalSecurityGroups <br /> *string array* | AdditionalSecurityGroups attaches additional security groups (e.g. i-123456)
additionalUserData <br /> *[UserData](#userdata-v1alpha2-kops) array* | AdditionalUserData is any aditional user-data to be passed to the host
additionalUserData <br /> *[UserData](#userdata-v1alpha2-kops) array* | AdditionalUserData is anyadditional user-data to be passed to the host
Copy link
Contributor

@bittopaz bittopaz Sep 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is needed in "anyadditional".

@justinsb
Copy link
Member

justinsb commented Oct 1, 2019

Thanks @hwdef - some of these were originally generated files, but it looks like they may have become detached from their generation. Thanks for fixing!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hwdef, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit b2e03d6 into kubernetes:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bittopaz bittopaz bittopaz left review comments

@granular-ryanbonham granular-ryanbonham Awaiting requested review from granular-ryanbonham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

@gambol99 gambol99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hwdef @k8s-ci-robot @justinsb @bittopaz @gambol99