-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ci postsubmit script for pushing images to staging #7697
Add ci postsubmit script for pushing images to staging #7697
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6128828
to
ebcb776
Compare
/retest |
/test pull-kops-e2e-kubernetes-aws |
- name: 'gcr.io/k8s-testimages/bazelbuild:v20190916-ec59af8-0.29.1' | ||
entrypoint: make | ||
env: | ||
- VERSION=$_GIT_TAG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the kops-controller-push
make target, does KOPS_CONTROLLER_TAG
need to be defined?
Line 916 in bb36e26
DOCKER_REGISTRY=${DOCKER_REGISTRY} DOCKER_IMAGE_PREFIX=${DOCKER_IMAGE_PREFIX} KOPS_CONTROLLER_TAG=${KOPS_CONTROLLER_TAG} bazel run //cmd/kops-controller:push-image |
/test pull-kops-verify-generated |
I'm not fully sure how this will work but because its a new CI job that shouldnt affect anything else... /lgtm |
@justinsb: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is the GCB script that will be called to automatically push images to our staging repo from a prow postsubmit job. That job is kubernetes/test-infra#14503