Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ci postsubmit script for pushing images to staging #7697

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Sep 27, 2019

This is the GCB script that will be called to automatically push images to our staging repo from a prow postsubmit job. That job is kubernetes/test-infra#14503

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2019
@justinsb justinsb force-pushed the upload_kops_controller branch from 6128828 to ebcb776 Compare September 27, 2019 20:55
@justinsb
Copy link
Member Author

/retest

@justinsb justinsb changed the title WIP: Add ci script Add ci postsubmit script for pushing images to staging Sep 27, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2019
@justinsb
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws

- name: 'gcr.io/k8s-testimages/bazelbuild:v20190916-ec59af8-0.29.1'
entrypoint: make
env:
- VERSION=$_GIT_TAG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the kops-controller-push make target, does KOPS_CONTROLLER_TAG need to be defined?

kops/Makefile

Line 916 in bb36e26

DOCKER_REGISTRY=${DOCKER_REGISTRY} DOCKER_IMAGE_PREFIX=${DOCKER_IMAGE_PREFIX} KOPS_CONTROLLER_TAG=${KOPS_CONTROLLER_TAG} bazel run //cmd/kops-controller:push-image

@rifelpet
Copy link
Member

/test pull-kops-verify-generated

@rifelpet
Copy link
Member

rifelpet commented Nov 6, 2019

I'm not fully sure how this will work but because its a new CI job that shouldnt affect anything else...

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit e8a64f5 into kubernetes:master Nov 6, 2019
@k8s-ci-robot
Copy link
Contributor

@justinsb: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kops-e2e-kubernetes-aws ebcb776 link /test pull-kops-e2e-kubernetes-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants