Fix mkdocs #7591
Merged
Fix mkdocs #7591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
mikesplain
force-pushed
the
fix_mkdics
branch
from
77e517f to
853d702
Compare
rifelpet
reviewed
Sep 13, 2019
mikesplain
force-pushed
the
fix_mkdics
branch
from
853d702 to
9998742
Compare
mikesplain
force-pushed
the
fix_mkdics
branch
from
9998742 to
7df8242
Compare
|
/lgtm one day we'll have a live docs site! |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr should help fix the mkdocs setup. Thanks to @aledbf for all his hard work getting this going!
I moved requirements to be inside the container it's self and built our own container much like ingress-nginx. I've also fixed the nodejs readme that was breaking the builds.
In future PRs I plan to cleanup some docs and reorganize things prior to us publishing these docs.