Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dropped Errors in upup #7586

Merged
merged 1 commit into from
Sep 14, 2019
Merged

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Sep 13, 2019

upup/pkg/fi/cloudup/openstacktasks: fix dropped error
upup/pkg/fi/cloudup/awstasks: fix dropped error
upup/pkg/fi/nodeup: fix dropped error

This PR picks off a few dropped errors under upup.

upup/pkg/fi/cloudup/openstacktasks: fix dropped error

upup/pkg/fi/nodeup: fix dropped error
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2019
@alrs
Copy link
Contributor Author

alrs commented Sep 13, 2019

/assign @justinsb

@justinsb
Copy link
Member

Thanks @alrs

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alrs, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit f2ecbd5 into kubernetes:master Sep 14, 2019
k8s-ci-robot added a commit that referenced this pull request Sep 16, 2019
…86-origin-release-1.14

Automated cherry pick of #7586: upup/pkg/fi/cloudup/awstasks: fix dropped error
k8s-ci-robot added a commit that referenced this pull request Sep 16, 2019
…86-origin-release-1.15

Automated cherry pick of #7586: upup/pkg/fi/cloudup/awstasks: fix dropped error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants