Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Associate subnets to port within OpenStack #7578

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Associate subnets to port within OpenStack #7578

merged 2 commits into from
Sep 13, 2019

Conversation

mitch000001
Copy link
Contributor

This PR fixes the association of nodes to the specified subnets, valuing their IP ranges.

Previously the instances were moved within the zone of the subnets but the ports of the instances were not associated to the right subnet and IP range.

@k8s-ci-robot
Copy link
Contributor

Welcome @mitch000001!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @mitch000001. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 13, 2019
zetaab
zetaab requested changes Sep 13, 2019
View reviewed changes
pkg/model/openstackmodel/servergroup.go
}
subnets = append(subnets, b.LinkToSubnet(s(fmt.Sprintf("%s.%s", subnet, b.ClusterName()))))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not going to work with PR #7577 the subnet name is not hardcoded like this anymore

@zetaab
Copy link
Member

zetaab commented Sep 13, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 13, 2019
@mitch000001 mitch000001 force-pushed the associate-subnets-to-port branch from aa5191e to eb41cdd Compare September 13, 2019 10:13
@mitch000001
chore(openstack): add tests to server group model builder
cf8cfbe
@mitch000001
chore(provider/openstack): use ips from associated subnets
b2f3963 
This changes values the provided instance group subnet and uses the IPs
from that subnet.
@mitch000001 mitch000001 force-pushed the associate-subnets-to-port branch from eb41cdd to b2f3963 Compare September 13, 2019 10:21
@mitch000001
Copy link
Contributor Author

/area area/provider/openstack

@k8s-ci-robot
Copy link
Contributor

@mitch000001: The label(s) area/area/provider/openstack cannot be appled. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

/area area/provider/openstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zetaab
zetaab approved these changes Sep 13, 2019
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2019
mikesplain
mikesplain approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mitch000001!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, mitch000001

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7da0d1a into kubernetes:master Sep 13, 2019
@mitch000001 mitch000001 deleted the associate-subnets-to-port branch September 13, 2019 14:51
@mitch000001 mitch000001 mentioned this pull request Sep 23, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 23, 2019
@k8s-ci-robot
Merge pull request #7650 from mitch000001/cherrypick-7578
4d74a87 
Cherry pick of #7578 onto release-1.15
@mitch000001 mitch000001 mentioned this pull request Sep 25, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 25, 2019
@k8s-ci-robot
Merge pull request #7670 from mitch000001/cherry-pick-7578-1.14
24ae588 
Cherry pick #7578 into release 1.14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab zetaab approved these changes

@mikesplain mikesplain mikesplain approved these changes

@drekle drekle Awaiting requested review from drekle

Assignees

@mikesplain mikesplain

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mitch000001 @k8s-ci-robot @zetaab @mikesplain