Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeleteLocalData on drain #7510

Merged
merged 1 commit into from
Sep 3, 2019
Merged

DeleteLocalData on drain #7510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/instancegroups/instancegroups.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,9 +333,11 @@ func (r *RollingUpdateInstanceGroup) DrainNode(u *cloudinstances.CloudInstanceGr
Out: os.Stdout,
ErrOut: os.Stderr,

// We want to proceed even when pods are using local data (emptyDir)
DeleteLocalData: true,

// Other options we might want to set:
// Timeout?
// DeleteLocalData?
}

if err := drain.RunCordonOrUncordon(helper, u.Node, true); err != nil {
Expand Down