Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upup/models/cloudup/resources/addons/coredns.addons.k8s.io) missing resourceVersion #7477

Merged
merged 1 commit into from
Sep 7, 2019
Merged

Conversation

phspagiari
Copy link
Contributor

This PR fixes a protokube error while applying the coredns addon. We can see the same behavior (already fixed) on kubeadm using kube-dns

Error logs

I0826 22:05:34.677310   14969 addon.go:130] Applying update from "s3://BUCKET-STATE-STORE/CLUSTER-NAME/addons/coredns.addons.k8s.io/k8s-1.12.yaml"
I0826 22:05:34.677339   14969 s3fs.go:220] Reading file "s3://BUCKET-STATE-STORE/CLUSTER-NAME/addons/coredns.addons.k8s.io/k8s-1.12.yaml"
I0826 22:05:34.693912   14969 apply.go:67] Running command: kubectl apply -f /tmp/channel974681140/manifest.yaml
I0826 22:05:34.853468   14969 apply.go:70] error running kubectl apply -f /tmp/channel974681140/manifest.yaml
The Service "coredns" is invalid: metadata.resourceVersion: Invalid value: "": must be specified for an update
Error: error updating "coredns.addons.k8s.io": error applying update from "coredns.addons.k8s.io/k8s-1.12.yaml": error running kubectl
Usage:
  channels apply channel [flags]

Flags:
  -f, --filename strings   Apply from a local file
  -h, --help               help for channel
      --yes                Apply update

Global Flags:
      --alsologtostderr                  log to standard error as well as files
      --config string                    config file (default is $HOME/.channels.yaml)
      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
      --log_dir string                   If non-empty, write log files in this directory
      --log_file string                  If non-empty, use this log file
      --log_file_max_size uint           Defines the maximum size a log file can grow to. Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
      --logtostderr                      log to standard error instead of files (default true)
      --skip_headers                     If true, avoid header prefixes in the log messages
      --skip_log_headers                 If true, avoid headers when openning log files
      --stderrthreshold severity         logs at or above this threshold go to stderr (default 2)
  -v, --v Level                          number for the log level verbosity (default 0)
      --vmodule moduleSpec               comma-separated list of pattern=N settings for file-filtered logging


error updating "coredns.addons.k8s.io": error applying update from "coredns.addons.k8s.io/k8s-1.12.yaml": error running kubectl
W0826 22:05:34.854816    2243 kube_boot.go:157] error applying channel "s3://BUCKET-STATE-STORE/CLUSTER-NAME/addons/bootstrap-channel.yaml": error running channels: exit status 1

After fix:

I0826 22:18:38.134799   29343 s3fs.go:220] Reading file "s3://BUCKET-STATE-STORE/CLUSTER-NAME/addons/bootstrap-channel.yaml"
I0826 22:18:38.165114   29343 addons.go:113] Skipping version range "<1.6.0" that does not match current version 1.13.10
I0826 22:18:38.165140   29343 addons.go:113] Skipping version range ">=1.6.0 <1.12.0" that does not match current version 1.13.10
I0826 22:18:38.165149   29343 addons.go:113] Skipping version range "<1.6.0" that does not match current version 1.13.10
I0826 22:18:38.165155   29343 addons.go:113] Skipping version range ">=1.6.0 <1.12.0" that does not match current version 1.13.10
I0826 22:18:38.165161   29343 addons.go:113] Skipping version range "<1.7.0" that does not match current version 1.13.10
I0826 22:18:38.165167   29343 addons.go:113] Skipping version range ">=1.7.0 <1.12.0" that does not match current version 1.13.10
No update required

Thanks @deadc ❤️

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 26, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @phspagiari. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@phspagiari phspagiari changed the title fix(upup/models/cloudup/resources/addons/coredns.addons.k8s.io) missing resourceVersio fix(upup/models/cloudup/resources/addons/coredns.addons.k8s.io) missing resourceVersion Aug 26, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 26, 2019
@chrisz100
Copy link
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 28, 2019
@chrisz100
Copy link
Contributor

/test pull-kops-e2e-kubernetes-aws

Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran into this today, thanks for the fix @phspagiari!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, phspagiari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 69a31b7 into kubernetes:master Sep 7, 2019
k8s-ci-robot added a commit that referenced this pull request Oct 5, 2019
k8s-ci-robot added a commit that referenced this pull request Oct 6, 2019
oded7hoffman pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jan 23, 2023
…k_7477_release-1.14

Cherry pick of kubernetes#7477 onto release-1.14
oded7hoffman pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jan 23, 2023
…k_7477_release-1.13

Cherry pick of kubernetes#7477 onto release-1.13
oded7hoffman pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jan 23, 2023
…k_7477_release-1.13

Cherry pick of kubernetes#7477 onto release-1.13
oded7hoffman pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jan 23, 2023
…k_7477_release-1.14

Cherry pick of kubernetes#7477 onto release-1.14
oded7hoffman pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jan 23, 2023
…k_7477_release-1.13

Cherry pick of kubernetes#7477 onto release-1.13
oded7hoffman pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jan 23, 2023
…k_7477_release-1.14

Cherry pick of kubernetes#7477 onto release-1.14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants