Update to kubernetes 1.15 #7470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the automatic translation from Gopkg that go.mod does.
We need to pin our dependencies in go.mod, at least until everything is fully go.mod
k8s-ci-robot
added
cncf-cla: yes
justinsb
requested review from
mikesplain
and removed request for
robinpercy and
granular-ryanbonham
|
@mikesplain I know you mentioned doing this, but this got onto the critical path for me and proved (much) more complicated than I had anticipated. If you have it though we should obviously use yours! |
justinsb
force-pushed
the
update_to_k115
branch
2 times, most recently
from
f2bcbf7 to
c988c80
Compare
|
This is great! Thanks so much! I did give this a shot a few weeks ago but didn’t get a chance to finish it up, so I’m totally cool with this. I’ll do a full review in a bit. Thanks! |
We also lock our go.sum files
We will replace with CRDs
Automatically generated vendor & BUILD.bazel files
justinsb
force-pushed
the
update_to_k115
branch
from
c988c80 to
08c6f0c
Compare
|
/retest |
mikesplain
approved these changes
Aug 26, 2019
| package kops | ||
|
|
||
| import ( | ||
| // For gazelle tests without requiring bazel |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
removed
the
lgtm
|
May also need to run |
Seeing an odd error from the apply, likely from an empty object: `error validating data: [apiVersion not set, kind not set]; if you choose to ignore these errors, turn validation off with --validate=false`
kubernetes/kubernetes#72137 appears to have introduced spurious spaces, but I think we can live with it for now.
justinsb
force-pushed
the
update_to_k115
branch
2 times, most recently
from
5d36af6 to
aa40390
Compare
Also fix hack/make-apimachinery.sh script problem with files that are not marked writeable.
justinsb
force-pushed
the
update_to_k115
branch
from
aa40390 to
4092849
Compare
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big win: we can use go modules!
Also: remove kops-server