[DO-7148] Digital Ocean support for etcd-manager #7435
Conversation
k8s-ci-robot
added
needs-ok-to-test
|
Hi @srikiz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
the
lgtm
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/assign @gambol99 |
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| @@ -394,7 +394,7 @@ func (b *EtcdManagerBuilder) buildPod(etcdCluster *kops.EtcdClusterSpec) (*v1.Po | |||
| config.VolumeProvider = "do" | |||
|
|
|||
| config.VolumeTag = []string{ | |||
| fmt.Sprintf("kubernetes.io/cluster/%s=owned", b.Cluster.Name), | |||
| fmt.Sprintf("kubernetes.io/cluster=%s", b.Cluster.Name), | |||
There was a problem hiding this comment.
Hmmm... can we follow the pattern that we use elsewhere (the kubernetes.io/cluster/<clustername> key). I'm assuming that keys are unique in DO also, and the reason is that the kubernetes.io/cluster=<clustername> pattern does not allow for shared objects. Admittedly sharing a volume would be weird, but sharing e.g. VPCs on AWS is pretty common.
This probably isn't as important on DO today, but it's unimportant until we find the first object we want to share :-)
There was a problem hiding this comment.
Sure @justinsb - this change would in-turn need a change to etcd-manager repo as well. May be we can get this merged if you are Ok, and then I'll take this separately to update both KOPS and etcd-manager repo. Please suggest if this sounds Ok for you.
|
Thanks @srikiz /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, srikiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Cherry pick of #7435 onto release-1.14
This PR incorporates changes to use etcd-manager, instead of the legacy mode.
Able to see the cluster coming up Ok with this change.
Please refer to the etcdmanager PR that is merged (kopeio/etcd-manager#243) to incorporate DigitialOcean related changes.