"Force" k8s 1.11.10 #7423
Merged
"Force" k8s 1.11.10 #7423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
|
Looks like we'll need to bump the kubernetesVersion, under kopsVersions. |
|
/retest |
|
Hmm, @justinsb is there any reason we shouldn't be doing something like this too? Which as @rdrgmnzs pointed out, will likely fix the tests, or at least did for me locally. |
Even 1.11 and 1.12 are technically unsupported, but this should get users off the very oldest unsupported versions of k8s. Users that want to stay on those versions can pass the KOPS_RUN_OBSOLETE_VERSION env var.
justinsb
force-pushed
the
alpha_channel_force_updates
branch
from
d82b11b to
61f3576
Compare
k8s-ci-robot
added
size/M
|
Good idea @mikesplain .. we really don't want to be encouraging use of those older kops versions at this point - particularly as newer kops versions should still work with older k8s versions! |
|
Thanks @justinsb! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Sep 14, 2019
Bringing this from the alpha channel (kubernetes#7423) to the stable channel. As discussed in office hours, and from the notes on kubernetes#7423: Even 1.11 and 1.12 are technically unsupported, but this should get users off the very oldest unsupported versions of k8s. Users that want to stay on those versions can pass the KOPS_RUN_OBSOLETE_VERSION env var.
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Sep 14, 2019
Bringing this from the alpha channel (kubernetes#7423) to the stable channel. As discussed in office hours, and from the notes on kubernetes#7423: Even 1.11 and 1.12 are technically unsupported, but this should get users off the very oldest unsupported versions of k8s. Users that want to stay on those versions can pass the KOPS_RUN_OBSOLETE_VERSION env var.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even 1.11 and 1.12 are technically unsupported, but this should get
users off the very oldest unsupported versions of k8s.
Users that want to stay on those versions can pass the
KOPS_RUN_OBSOLETE_VERSION env var.