Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upate Lyft CNI to v0.5.1 #7402

Merged
merged 5 commits into from
Nov 20, 2019
Merged

Conversation

maruina
Copy link
Contributor

@maruina maruina commented Aug 13, 2019

This PR:

  • Update the Lyft CNI to v0.5.1
  • Add a new IAM policy because ec2:DescribeVpcs is required for m5 and c5 instances because the AWS metadata server does not return the secondary CIDR block on these instance types.
  • Add the Lyft CNI to the documentation

Marked as WIP because I still need to test this build by spinning up a new cluster, but I'm happy to get any feedback if you something that doesn't look right.
Tested by creating a new cluster and upgrading an existing one.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @maruina. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 13, 2019
docs/networking.md Outdated Show resolved Hide resolved
@rifelpet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2019
@phyllisstein
Copy link

phyllisstein commented Sep 7, 2019

Particularly jazzed about the documentation! I might propose adding a note about the creating a VPC in advance and setting spec.networkID. Probably should have been self-evident from the CNI docs, but I wound up struggling to get the sequence straight anyway.

ETA: You're gonna have a bad time, though: the upstream team forgot to build the binaries for the v0.5.0 release 🤦‍♂.

@maruina maruina force-pushed the lyft-cni-v0.5.0 branch 2 times, most recently from fb593c1 to 8d30143 Compare October 31, 2019 14:42
@maruina
Copy link
Contributor Author

maruina commented Nov 8, 2019

This has been tested in the following scenario:

  • updating a cluster running lyft 0.4.0 to 0.5.0
  • spinning up a lyft 0.5.0 cluster

I think the only thing missing before merging this is where to store the binaries :)

@maruina
Copy link
Contributor Author

maruina commented Nov 8, 2019

@phyllisstein I updated the docs, please tell me if it makes more sense

@phyllisstein
Copy link

Thanks for indulging my confusion, and thanks again for the extra docs.

Co-Authored-By: David Byron <[email protected]>
@maruina maruina changed the title [WIP] Upate Lyft CNI to v0.5.0 Upate Lyft CNI to v0.5.1 Nov 19, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2019
@maruina
Copy link
Contributor Author

maruina commented Nov 19, 2019

The binary has been built by Lyft, so we can review (and hopefully merge) this.

@rifelpet
Copy link
Member

Thanks for sticking with it!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2019
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maruina!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maruina, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit a7ebaf7 into kubernetes:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants