-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upate Lyft CNI to v0.5.1 #7402
Upate Lyft CNI to v0.5.1 #7402
Conversation
Hi @maruina. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Particularly jazzed about the documentation! I might propose adding a note about the creating a VPC in advance and setting ETA: You're gonna have a bad time, though: the upstream team forgot to build the binaries for the |
fb593c1
to
8d30143
Compare
This has been tested in the following scenario:
I think the only thing missing before merging this is where to store the binaries :) |
8d30143
to
a97d627
Compare
@phyllisstein I updated the docs, please tell me if it makes more sense |
Thanks for indulging my confusion, and thanks again for the extra docs. |
Co-Authored-By: David Byron <[email protected]>
a97d627
to
7a581f0
Compare
The binary has been built by Lyft, so we can review (and hopefully merge) this. |
Thanks for sticking with it! /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maruina!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maruina, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR:
ec2:DescribeVpcs is required for m5 and c5 instances because the AWS metadata server does not return the secondary CIDR block on these instance types.
Marked as WIP because I still need to test this build by spinning up a new cluster, but I'm happy to get any feedback if you something that doesn't look right.Tested by creating a new cluster and upgrading an existing one.