-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Cluster Proportional Autoscaler for CoreDNS 1.12+ #7400
Conversation
Follow the example of Kube-DNS for scaling the CoreDNS deployment by use of a cluster proportional autoscaler
Hi @gjtempleton. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
command: | ||
- /cluster-proportional-autoscaler | ||
- --namespace=kube-system | ||
- --configmap=coredns-autoscaler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this configmap exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the proportional autoscaler creates it itself, that's why the ClusterRole
has the ability to create configmaps within it.
kubernetes-sigs/cluster-proportional-autoscaler#16 has been closed due to staleness, so don't see this being resolved soon.
/ok-to-test |
Looks great! Upstream is here https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns-horizontal-autoscaler/dns-horizontal-autoscaler.yaml and it uses the kube-dns-autoscaler name, but that just seems wrong - it means we couldn't allow kube-dns and coredns to coexist, for example. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Follow the example of Kube-DNS for scaling the CoreDNS deployment by use of a cluster proportional autoscaler. Also adds a 10%
maxSurge
tolerance.YAML added is near identical to the existing CPA and associate roles etc. used in https://github.com/kubernetes/kops/blob/master/upup/models/cloudup/resources/addons/kube-dns.addons.k8s.io/k8s-1.12.yaml.template
Mutually exclusive with #6797