Update Calico manifests to better match the latest release

[tmjd]

• Adds mounts for Application layer policy https://docs.projectcalico.org/v3.8/security/app-layer-policy/
• Re-organizes manifest to better match (reduce differences) with source
  Calico manifests.
  https://docs.projectcalico.org/v3.8/manifests/calico-etcd.yaml
  https://docs.projectcalico.org/v3.8/manifests/calico.yaml
• Switch install-cni container to initContainer
• Fix critical annotation on kube-controller

[k8s-ci-robot]

Hi @tmjd. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tmjd
To complete the pull request process, please assign mikesplain
You can assign the PR to them by writing /assign @mikesplain in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tmjd]

/assign @mikesplain

[tmjd]

I've tested this out by:

• installing with my changes
• Installing a cluster with kops v1.13 and then updating with my changes.
• Enabling Calico Application Layer Policy https://docs.projectcalico.org/v3.8/security/app-layer-policy/ and verifying by following the tutorial at the link.

[tmjd]

I don't want this PR to get too out of date. What is the next step needed here?

[miguelbernadi]

This Pr is also very interesting for my case as it adds the PriorityClassName to calico. We recently added PriorityClasses to the cluster for our apps and calico-node got evicted due to receiving the default (lowest) priority. Would be very glad to see it become part of a patch release for 1.13.

[mikesplain]

Hey @tmjd sorry for the delay on this, let me dive in a bit and get back to you. I recently did a similar update so I need to make sure these line up right. Also, I really think we should only be updating the v1.12 manifest because we don't run any tests against those old versions and really do not support them any more given our deprecation policy. That said, I really really appreciate your work on this and the contribution! I'll setup a reminder to look at this later this week when I can give it the time it deserves.

[hakman]

@tmjd @mikesplain I think #8104 does something similar for latest Calico manifest.

[k8s-ci-robot]

@tmjd: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[mikesplain]

Since this has been since handled, closing. Sorry for the delay and thanks for the contribution.

/close

[k8s-ci-robot]

@mikesplain: Closed this PR.

In response to this:

Since this has been since handled, closing. Sorry for the delay and thanks for the contribution.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.