Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add artifacts.k8s.io to mirror list #7378

Merged
merged 1 commit into from
Oct 12, 2019
Merged

Add artifacts.k8s.io to mirror list #7378

merged 1 commit into from
Oct 12, 2019

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Aug 4, 2019

The official mirror is coming!

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 4, 2019
@justinsb
Copy link
Member Author

justinsb commented Aug 4, 2019

WIP: relies on kubernetes/k8s.io#326

@justinsb justinsb force-pushed the add_artifacts_k8s_io branch from 0ab3435 to 6118904 Compare August 4, 2019 05:38
@justinsb justinsb force-pushed the add_artifacts_k8s_io branch from 6118904 to 84ea245 Compare August 19, 2019 04:08
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2019
@justinsb justinsb changed the title WIP: Add artifacts.k8s.io to mirror list add artifacts.k8s.io to mirror list Aug 19, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2019
@justinsb justinsb changed the title add artifacts.k8s.io to mirror list Add artifacts.k8s.io to mirror list Aug 19, 2019
@justinsb
Copy link
Member Author

Not actually WIP because we can introduce mirrors freely, even when they aren't fully populated, because by design we fall back.

mikesplain
mikesplain approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @justinsb!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justinsb,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikesplain
Copy link
Contributor

/retest

@justinsb justinsb force-pushed the add_artifacts_k8s_io branch from 84ea245 to 9730f3a Compare September 26, 2019 14:49
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2019
@justinsb
Copy link
Member Author

/retest

PV flake

@justinsb
Add artifacts.k8s.io to mirror list
4e1e596 
The official mirror is coming!
@justinsb justinsb force-pushed the add_artifacts_k8s_io branch from 9730f3a to 4e1e596 Compare September 30, 2019 16:04
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2019
@justinsb
Copy link
Member Author

justinsb commented Oct 1, 2019

I'd like to get this into 1.15 beta if possible - mind taking a (hopefully final) look @mikesplain ?

@justinsb justinsb mentioned this pull request Oct 1, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request Oct 1, 2019
@k8s-ci-robot
Merge pull request #7722 from justinsb/automated-cherry-pick-of-#7378…
8787c88 
…-origin-release-1.15

Automated cherry pick of #7378: Add artifacts.k8s.io to mirror list
@justinsb
Copy link
Member Author

/retest

@rifelpet
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1bb829b into kubernetes:master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesplain mikesplain mikesplain approved these changes

@granular-ryanbonham granular-ryanbonham Awaiting requested review from granular-ryanbonham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@mikesplain mikesplain

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justinsb @k8s-ci-robot @mikesplain @rifelpet