Add --wait argument to kops validate #7371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
justinsb
force-pushed
the
kops_validate_now_supports_wait
branch
from
e81f6c2 to
b00838f
Compare
With this argument, kops validate will poll until the timeout expires, waiting for readiness. On readiness or on timer expiration, it exits as if wait was not present.
justinsb
force-pushed
the
kops_validate_now_supports_wait
branch
from
b00838f to
6a6bd7d
Compare
|
I'd really like to get this one in ... it is really helpful for tests :-) |
mikesplain
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
I guess we can add another flag for this 😉! Thanks @justinsb!
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test pull-kops-e2e-kubernetes-aws |
This was referenced Sep 20, 2019
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 20, 2019
…71-origin-release-1.15 Automated cherry pick of #7371: Add --wait argument to kops validate
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 20, 2019
…71-origin-release-1.14 Automated cherry pick of #7371: Add --wait argument to kops validate
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this argument, kops validate will poll until the timeout expires,
waiting for readiness. On readiness or on timer expiration, it exits
as if wait was not present.