-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mappings for Webhook authorization mode. #7344
Add mappings for Webhook authorization mode. #7344
Conversation
Welcome @anderseknert! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @anderseknert. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/check-cla |
Thanks for the contribution @anderseknert ! /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great and love the unit tests!
@@ -266,6 +266,13 @@ func validateKubeAPIServer(v *kops.KubeAPIServerConfig, fldPath *field.Path) fie | |||
} | |||
} | |||
|
|||
if v.AuthorizationMode != nil && strings.Contains(*v.AuthorizationMode, "Webhook") { | |||
if v.AuthorizationWebhookConfigFile == nil { | |||
flds := [2]*string{v.AuthorizationMode, v.AuthorizationWebhookConfigFile} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an unusual syntax - I would have expected you could just use []*string{ v.AuthorizationMode, v.AuthorizationWebhookConfigFile}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I literally wrote my first lines of Go last week, so any unusual syntax is more due to incompetence rather than any desire to be different ;) In this case though I think I saw this syntax used on line 257 above and figured there's probably a point in doing it like that.
Thanks @anderseknert /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anderseknert, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #7344 onto release-1.14
Adding the missing parameters I reported as an issue the other day. First PR in a go repository so bear with me. Had a look at previous similar addition an tried to figure it out from there. Added a few tests to verify and tested setting up a new cluster with the added parameters as well.