Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machine types fix #7300

Merged

Conversation

mikesplain
Copy link
Contributor

  • m5a.8xlarge fixed
  • i3en.metal has been removed from api's and all docs I can find.

@k8s-ci-robot k8s-ci-robot requested a review from andrewsykim July 22, 2019 12:56
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 22, 2019
@k8s-ci-robot k8s-ci-robot requested a review from geojaz July 22, 2019 12:56
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 22, 2019
@justinsb
Copy link
Member

Thanks @mikesplain - "the case of the disappearing i3en.metal" is indeed perplexing :-).

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justinsb,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2cbf735 into kubernetes:master Jul 22, 2019
@mikesplain mikesplain deleted the remove_i3en.metal_fix_m5a.8xlarge branch July 22, 2019 17:57
k8s-ci-robot added a commit that referenced this pull request Jul 22, 2019
…00-origin-release-1.13

Automated cherry pick of #7300: Fix m5a.8xlarge and i3en.metal has been removed
k8s-ci-robot added a commit that referenced this pull request Jul 22, 2019
…00-origin-release-1.14

Automated cherry pick of #7300: Fix m5a.8xlarge and i3en.metal has been removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants