-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rhel8 support #7287
Rhel8 support #7287
Conversation
Hi @neoakris. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
This looks great, thanks for rebasing @neoakris . The switch from ntp to chrony will take place also for rhel7, which I guess is OK - typically we have tried not to change behavior on previous versions, but in this case I think we can just add it to the release notes for whatever version we first cherry-pick this back to! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, neoakris The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
(Also, I have an open PR to move that to code, so I'll likely just update that one to keep rhel7 / centos7 using the ntp package ... unless there is some reason we should actively change rhel7 / centos7?) |
Cherry pick of #7287 onto release-1.14
Ran some directions as per
#7130
here's what I've done
git clone [email protected]:VibrentHealth/kops.git
cd kops
git remote add upstream https://github.com/kubernetes/kops
git fetch upstream
git merge upstream/master
git push origin
//(our fork's master is now synced with upstream master)
git checkout -b rhel8_support
git cherry-pick f449e61
git cherry-pick 592d7cd
git cherry-pick 05c5af4
git diff master
//(makes it look like only the desired diff is captured)
Created this new PR
Also worth mentioning: I looked into signing the CLA, and to my knowledge, the VibrentHealth organization signed it, and since myself and Cassandra are part of that organization we're good. Let me know if I'm mistaken on that.