Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue-7148] Legacyetcd support for Digital Ocean #7221

Merged
merged 1 commit into from
Jul 19, 2019
Merged

[Issue-7148] Legacyetcd support for Digital Ocean #7221

merged 1 commit into from
Jul 19, 2019

Conversation

srikiz
Copy link
Contributor

@srikiz srikiz commented Jul 5, 2019 •
edited
Loading

Couple of updates to get digitial ocean cloud provider working with the latest master.

  • Updated the digital ocean cloud manager to an updated version - 0.1.15

  • Update KOPS_FEATURE_FLAGS to also include an override flag, this is temporary, I'll be adding the next set of changes to include support for etcd-manager, but until then we can use legacy support.

  • Update etcd manager for DO cloud provider, so we don't get a not supported error. will be adding another PR for more changes to the etcdmanager repo to support DO.

Note: I have tested this change and it seems to work on release-1.12, release-1.13 and release-1.14 branches. I believe there is some issue with the latest master, I didn't see any logs generated in the master linux server once I SSH to it. If this gets approved, I would like to cherry pick this into release-1.13 or release-1.14 based on your suggestion.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 5, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @srikiz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 5, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 5, 2019
@mikesplain
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 8, 2019
@justinsb
Copy link
Member

Thanks for this! One suggestion about only changing the TTL for DO, if we can avoid it, but otherwise it looks good.

I think you need to run make gazelle to regenerate the bazel, for the tests to pass.

@srikiz
Copy link
Contributor Author

srikiz commented Jul 11, 2019

Thanks for this! One suggestion about only changing the TTL for DO, if we can avoid it, but otherwise it looks good.

I think you need to run make gazelle to regenerate the bazel, for the tests to pass.

Sure, will make the change.

@srikiz
Copy link
Contributor Author

srikiz commented Jul 11, 2019

@justinsb - On the same note, I will be working on supporting etcd-manager for DO in the next coming days. I intend to make changes to the etcd-manager repository to support DO cloud provider. Please let me know if this direction sounds Ok. Or you suggest any other alternatives?

FYI - @timoreimann

@srikiz
Copy link
Contributor Author

srikiz commented Jul 11, 2019

@justinsb @andrewsykim - Incorporated review comments, please have a look and /approve if you are Ok.

@andrewsykim
Copy link
Member

@srikiz can you squash commits please?

@srikiz
Initial changes to add DO models for etcd-manager
6392725 
update template

Update notes for digital ocean

Update TTL to 60 seconds and version upgrade to 0.1.15 for DO Cloud Controller Manager

Update review comments

Format go code
@srikiz srikiz force-pushed the DO-7148-legacyetcdSupport branch from 0dadc65 to 6392725 Compare July 17, 2019 16:47
@srikiz
Copy link
Contributor Author

srikiz commented Jul 17, 2019

@srikiz can you squash commits please?

Done @andrewsykim - please have a look when you get a chance.

@timoreimann
Copy link

timoreimann commented Jul 18, 2019 •
edited
Loading

@srikiz I released CCM v0.1.16 yesterday. Do you think we could still squeeze that in?

Updating should be as simple as bumping the version in the manifest. Nothing else has changed.

If you'd like to punt this to a future PR, I'm also fine with that.

@timoreimann timoreimann mentioned this pull request Jul 19, 2019
Merged
@justinsb
Copy link
Member

LGTM - thanks for fixing the TTL issue!

Can we bump the c-c-m version separately - should be an easy PR to review!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, srikiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 039cee1 into kubernetes:master Jul 19, 2019
@timoreimann
Copy link

Followed up with #7293 to update the CCM version to v0.1.16.

@justinsb justinsb mentioned this pull request Aug 1, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request Aug 1, 2019
@k8s-ci-robot
Merge pull request #7358 from justinsb/cherrypick_7221_release-1.14
b6c1410 
Cherry pick of #7221 onto release-1.14
@srikiz srikiz deleted the DO-7148-legacyetcdSupport branch August 9, 2019 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoreimann timoreimann timoreimann left review comments

@justinsb justinsb justinsb left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@chrisz100 chrisz100 Awaiting requested review from chrisz100

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@srikiz @k8s-ci-robot @mikesplain @justinsb @andrewsykim @timoreimann