-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NodeAuthorizer config options instead of soely hard-codes #7211
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -189,6 +189,8 @@ type NodeAuthorizerSpec struct { | |
NodeURL string `json:"nodeURL,omitempty"` | ||
// Port is the port the service is running on the master | ||
Port int `json:"port,omitempty"` | ||
// Interval the time between retires for authorization request | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: typo - retries |
||
Interval *metav1.Duration `json:"interval,omitempty"` | ||
// Timeout the max time for authorization request | ||
Timeout *metav1.Duration `json:"timeout,omitempty"` | ||
// TokenTTL is the max ttl for an issued token | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -188,6 +188,8 @@ type NodeAuthorizerSpec struct { | |
NodeURL string `json:"nodeURL,omitempty"` | ||
// Port is the port the service is running on the master | ||
Port int `json:"port,omitempty"` | ||
// Interval the time between retires for authorization request | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. copy-paste of retires typo |
||
Interval *metav1.Duration `json:"interval,omitempty"` | ||
// Timeout the max time for authorization request | ||
Timeout *metav1.Duration `json:"timeout,omitempty"` | ||
// TokenTTL is the max ttl for an issued token | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -189,6 +189,8 @@ type NodeAuthorizerSpec struct { | |
NodeURL string `json:"nodeURL,omitempty"` | ||
// Port is the port the service is running on the master | ||
Port int `json:"port,omitempty"` | ||
// Interval the time between retires for authorization request | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: retires |
||
Interval *metav1.Duration `json:"interval,omitempty"` | ||
// Timeout the max time for authorization request | ||
Timeout *metav1.Duration `json:"timeout,omitempty"` | ||
// TokenTTL is the max ttl for an issued token | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah - you're right - it looks like we simply weren't using it! Thanks for fixing!