Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: support to debug kops-apiserver #7151

Merged
merged 1 commit into from
Jul 10, 2019
Merged

doc: support to debug kops-apiserver #7151

merged 1 commit into from
Jul 10, 2019

Conversation

Sn0rt
Copy link
Contributor

@Sn0rt Sn0rt commented Jun 17, 2019 •
edited
Loading

This script tests on aws as follows output:

kubectl -n kube-system logs kops-api-server-c4dbdfc54-dvmns -f

I0617 09:05:57.182345       1 serving.go:311] Generated self-signed cert (apiserver.local.config/certificates/apiserver.crt, apiserver.local.config/certificates/apiserver.key)
W0617 09:05:57.571489       1 start.go:133] Authentication/Authorization disabled
I0617 09:05:57.572928       1 plugins.go:158] Loaded 2 mutating admission controller(s) successfully in the following order: NamespaceLifecycle,MutatingAdmissionWebhook.
I0617 09:05:57.572944       1 plugins.go:161] Loaded 1 validating admission controller(s) successfully in the following order: ValidatingAdmissionWebhook.
W0617 09:05:57.620374       1 genericapiserver.go:338] Skipping API kops.k8s.io/v1alpha1 because it has no resources.
I0617 09:05:57.735572       1 secure_serving.go:116] Serving securely on [::]:443

and get

$ curl -k https://172.20.42.164/swagger.json
{
  "swagger": "2.0",
  "info": {
   "title": "Kops API",
   "version": "0.1"

Signed-off-by: guohaowang [email protected]

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 17, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @Sn0rt. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 17, 2019
@Sn0rt
Copy link
Contributor Author

Sn0rt commented Jun 17, 2019

the /api-server/README.md has been renamed with kops-server.

@justinsb
Copy link
Member

/ok-to-test

/lgtm

This looks good @Sn0rt - thank you (but I do encourage you to look into the upcoming CRD support instead...)

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2019
@justinsb
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, Sn0rt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2019
@justinsb
Copy link
Member

PR failure is a well-known flake: kubernetes/kubernetes#73099

Looks like you have a conflict with your other PR as well

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2019
@Sn0rt
doc: add doc to help developer to inspect kops-server
1653f0f 
```
$ kubectl -n kube-system logs kops-server-9dd887bcf-tfvkw
I0617 09:24:38.935898       1 serving.go:311] Generated self-signed cert (apiserver.local.config/certificates/apiserver.crt, apiserver.local.config/certificates/apiserver.key)
W0617 09:24:40.097484       1 start.go:133] Authentication/Authorization disabled
I0617 09:24:40.099018       1 plugins.go:158] Loaded 2 mutating admission controller(s) successfully in the following order: NamespaceLifecycle,MutatingAdmissionWebhook.
I0617 09:24:40.099034       1 plugins.go:161] Loaded 1 validating admission controller(s) successfully in the following order: ValidatingAdmissionWebhook.
W0617 09:24:40.139797       1 genericapiserver.go:338] Skipping API kops.k8s.io/v1alpha1 because it has no resources.
I0617 09:24:40.257371       1 secure_serving.go:116] Serving securely on [::]:443
```

and test get

```
$ curl -k https://172.20.42.164/swagger.json
{
  "swagger": "2.0",
  "info": {
   "title": "Kops API",
   "version": "0.1"
     ....
```

Signed-off-by: guohaowang <[email protected]>
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 21, 2019
@Sn0rt
Copy link
Contributor Author

Sn0rt commented Jun 21, 2019

/test pull-kops-e2e-kubernetes-aws

2 similar comments
@Sn0rt
Copy link
Contributor Author

Sn0rt commented Jun 24, 2019

/test pull-kops-e2e-kubernetes-aws

@Sn0rt
Copy link
Contributor Author

Sn0rt commented Jul 1, 2019

/test pull-kops-e2e-kubernetes-aws

@justinsb
Copy link
Member

/retest
/lgtm

I think the e2e issues should have been resolved now!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5e87f35 into kubernetes:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sn0rt @k8s-ci-robot @justinsb