Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs for openstack cloud provider. #7092

Merged

Conversation

prankul88
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @prankul88. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 4, 2019
@adisky
Copy link

adisky commented Jun 4, 2019

from code it seems the actual flag is AlphaAllowOpenstack, but its should be fixed in code or doc it is not clear, as we refer openstack as OpenStack
cc @zetaab

@chrisz100
Copy link
Contributor

/ok-to-test

Thank you for your work @prankul88 !
/assign @zetaab
Can you please check @adisky concerns before approval?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2019
@zetaab
Copy link
Member

zetaab commented Jun 4, 2019

@adisky yes we should refer to OpenStack instead of Openstack. However, if we change that behaviour now it will break things. As I see it this is not that huge problem that we should do it. Instead the next step that I want to see is that we remove this feature flag from OpenStack.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2019
@chrisz100
Copy link
Contributor

/approve

Thanks :-)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, prankul88

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2019
@adisky
Copy link

adisky commented Jun 4, 2019

@adisky yes we should refer to OpenStack instead of Openstack. However, if we change that behaviour now it will break things. As I see it this is not that huge problem that we should do it. Instead the next step that I want to see is that we remove this feature flag from OpenStack.

/lgtm

@zetaab Thanks!! yes i understand that.

@k8s-ci-robot k8s-ci-robot merged commit ffcd424 into kubernetes:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants