Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kops instancegroup tag to metadata #6991

Merged
merged 1 commit into from
May 16, 2019

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented May 16, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 16, 2019
@k8s-ci-robot k8s-ci-robot requested review from drekle and rdrgmnzs May 16, 2019 09:37
@KashifSaadat
Copy link
Contributor

/lgtm
/approve

Thanks @zetaab :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KashifSaadat, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zetaab
Copy link
Member Author

zetaab commented May 16, 2019

/test pull-kops-e2e-kubernetes-aws

@zetaab
Copy link
Member Author

zetaab commented May 16, 2019

/test pull-kops-verify-packages

@zetaab
Copy link
Member Author

zetaab commented May 16, 2019

/test pull-kops-verify-bazel

@k8s-ci-robot k8s-ci-robot merged commit 898f11d into kubernetes:master May 16, 2019
k8s-ci-robot added a commit that referenced this pull request May 17, 2019
k8s-ci-robot added a commit that referenced this pull request May 17, 2019
@zetaab zetaab deleted the feature/kopsigtometadata branch September 21, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants