-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Docker not being installed on Ubuntu 16.04 #6965
Fix Docker not being installed on Ubuntu 16.04 #6965
Conversation
This only affects the default Docker version for 1.12 (18.06.3).
Hi @meeee. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Thanks for spotting, reporting & fixing @meeee :-) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, meeee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kops-verify-bazel Looks like a test-infra flake - can't open logs |
Cherry pick of #6965 onto release-1.12
Cherry pick of #6965 onto release-1.13
Cherry pick of #6965 onto release-1.14
kops 1.12 uses a new Docker version by default (18.06.3), which nodeup has no package for on Ubuntu 16.04. This results in Docker not being installed when using 1.12-beta.2.
Fixes #6585.
This MR is against master - it probably makes sense to cherry-pick this into the
release-1.12
branch (and possibly others).Tested with a custom nodeup build on the
release-1.12
branch.