Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canal v3.7.2 for k8s v1.12+ #6950

Merged
merged 1 commit into from
May 13, 2019
Merged

Canal v3.7.2 for k8s v1.12+ #6950

merged 1 commit into from
May 13, 2019

Conversation

KashifSaadat
Copy link
Contributor

Changes:

  • Update Canal manifest to v3.7.2 for Kubernetes v1.12+
  • Re-ordering resources within the manifest to be more in-line with official docs

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KashifSaadat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2019
@KashifSaadat
Copy link
Contributor Author

Due to the resource re-ordering it's a little difficult to review this PR. Here's the 3 actual changes:

@gambol99
Copy link
Contributor

/lgtm
/aprrove

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit ddddeac into kubernetes:master May 13, 2019
@gambol99 gambol99 deleted the canal-v3.7.2 branch May 13, 2019 14:52
This was referenced May 17, 2019
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request May 17, 2019
@k8s-ci-robot
Merge pull request #7027 from granular-ryanbonham/cherrypick_6950_rel…
0151919 
…ease-1.13

Cherry pick of #6950 onto release-1.13
k8s-ci-robot added a commit that referenced this pull request May 17, 2019
@k8s-ci-robot
Merge pull request #7028 from granular-ryanbonham/cherrypick_6950_rel…
c467eea 
…ease-1.14

Cherry pick of #6950 onto release-1.14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@gambol99 gambol99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KashifSaadat @k8s-ci-robot @gambol99