Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate CRDs for kops API types #6891

Merged
merged 3 commits into from
May 14, 2019
Merged

Generate CRDs for kops API types #6891

merged 3 commits into from
May 14, 2019

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented May 7, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 7, 2019
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels May 7, 2019
@mikesplain mikesplain mentioned this pull request May 7, 2019
Closed
@mikesplain
Copy link
Contributor

Yay for CRDs! This looks pretty safe since nothing will be using it just yet. I've created an issue to make sure this stays up to date: #6892, I'll take a crack at that if you don't mind!

@mikesplain
Copy link
Contributor

/retest

mikesplain
mikesplain reviewed May 7, 2019
View reviewed changes
Makefile Show resolved Hide resolved
@mikesplain
Copy link
Contributor

/test pull-kops-e2e-kubernetes-aws

@mikesplain
Copy link
Contributor

Yay for CRDs!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justinsb,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c6d392e into kubernetes:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@mikesplain mikesplain mikesplain left review comments

@apelisse apelisse Awaiting requested review from apelisse

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@justinsb @mikesplain @k8s-ci-robot @rifelpet @apelisse