Start CRDification: Change apigroup to kops.k8s.io #6887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will continue to accept the kops/v1alphaN format, but we rewrite it (via string manipulation) to kops.k8s.io/v1alphaN. This allows us to register the kops types as CRDs, which in turn should enable kops server to work without API aggregation, and also reduce our dependencies on less-stable API machinery.
Autogenerated code, docs & test changes Also a new test for the older "kops" apiGroup, to make sure that continues to work.
k8s-ci-robot
added
cncf-cla: yes
|
This looks great! I’ll take a deeper look in a few. /assign |
|
/test pull-kops-e2e-kubernetes-aws |
k8s-ci-robot
added
the
lgtm
mikesplain
approved these changes
May 7, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename kops API group to be compatible with CRDS: kops.k8s.io
We will continue to accept the kops/v1alphaN format, but we rewrite it
(via string manipulation) to kops.k8s.io/v1alphaN.
This allows us to register the kops types as CRDs, which in turn
should enable kops server to work without API aggregation, and also
reduce our dependencies on less-stable API machinery.