Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/etc/hosts (gossip): More robust logic #6885

Merged
merged 1 commit into from
May 9, 2019
Merged

/etc/hosts (gossip): More robust logic #6885

merged 1 commit into from
May 9, 2019

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented May 6, 2019 •
edited
Loading

  • Add a mutex around /etc/hosts updates (for a little extra safety)
  • Don't write unchanged files
  • Recover from out-of-sequence guard lines
  • Add tests

Thanks to @granular-ryanbonham for the suggestions & finding the issue!

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 6, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2019
@justinsb justinsb changed the title WIP: /etc/hosts: Don't write unchanged files /etc/hosts (gossip): Stronger logic May 6, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2019
This was referenced May 6, 2019
Closed
Closed
@justinsb
Copy link
Member Author

justinsb commented May 6, 2019

cc @granular-ryanbonham

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 6, 2019
@justinsb justinsb force-pushed the etcd_hosts branch 2 times, most recently from 9ef871b to a8bbd13 Compare May 6, 2019 16:18
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 6, 2019
@justinsb justinsb changed the title /etc/hosts (gossip): Stronger logic /etc/hosts (gossip): More robustt logic May 6, 2019
@justinsb justinsb changed the title /etc/hosts (gossip): More robustt logic /etc/hosts (gossip): More robust logic May 6, 2019
@granular-ryanbonham
Copy link
Contributor

fixes #6699

@justinsb
Copy link
Member Author

justinsb commented May 6, 2019

/retest

CSI failures

@granular-ryanbonham
Copy link
Contributor

/test pull-kops-e2e-kubernetes-aws

@justinsb
/etc/hosts (gossip): Stronger logic
68e975c 
* Add a mutex around /etc/hosts updates (for a little extra safety)
* Don't write unchanged files
* Recover from out-of-sequence guard lines
* Add tests

Thanks to granular-ryanbonham for the suggestions & finding the issue!
@mikesplain
Copy link
Contributor

This looks great! Thanks @justinsb! I'll label this as a cherry pick as @granular-ryanbonham ran into this in 1.12-beta/alpha.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justinsb,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb
Copy link
Member Author

justinsb commented May 7, 2019

/retest

@justinsb justinsb mentioned this pull request May 7, 2019
Merged
@justinsb
Copy link
Member Author

justinsb commented May 7, 2019

/test pull-kops-e2e-kubernetes-aws

etcd credentials did not work with AWS. That's .... surprising; likely an infrastructure issue, but would like to see if this self-resolves.

@justinsb
Copy link
Member Author

justinsb commented May 8, 2019

/retest

@justinsb
Copy link
Member Author

justinsb commented May 8, 2019

/test pull-kops-e2e-kubernetes-aws

No instances started ... starting to worry about the AWS account

@justinsb
Copy link
Member Author

justinsb commented May 8, 2019

/retest

I believe this is kubernetes/test-infra#12527

@justinsb
Copy link
Member Author

justinsb commented May 8, 2019

/retest

Hoping to catch boskos in the act!

@justinsb
Copy link
Member Author

justinsb commented May 8, 2019

/retest

I think boskos should no longer be sweeping!

@justinsb
Copy link
Member Author

justinsb commented May 8, 2019

/retest

Back to CSI flakes - yay!

@justinsb
Copy link
Member Author

justinsb commented May 9, 2019

/retest

Known flake kubernetes/kubernetes#73099

@justinsb
Copy link
Member Author

justinsb commented May 9, 2019

/retest

CSI issues were probably due to #6899
This of course begs the question of how we sometimes pass without it, but that's a separate issue

@mikesplain
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 68e975c into kubernetes:master May 9, 2019
@k8s-ci-robot
Copy link
Contributor

@justinsb: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kops-e2e-kubernetes-aws 68e975c link /test pull-kops-e2e-kubernetes-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@granular-ryanbonham granular-ryanbonham mentioned this pull request May 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justinsb @granular-ryanbonham @mikesplain @k8s-ci-robot