-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Scale from 0 with Lauch Templates #6861
Support Scale from 0 with Lauch Templates #6861
Conversation
/lgtm Should be cherry picked to 1.12 / 1.13 / 1.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @granular-ryanbonham!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: granular-ryanbonham, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ck-of-#6861-upstream-release-1.12 Automated cherry pick of #6861 upstream release 1.12
…ck-of-#6861-upstream-release-1.14 Automated cherry pick of #6861 upstream release 1.14
…ck-of-#6861-upstream-release-1.13 Automated cherry pick of #6861 upstream release 1.13
When using LaunchTemplates we are missing a permission on masters to allow cluster autoscaler to function if you are trying to sale from 0.
https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/README.md