Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update etcd3-migration.md doc #6774

Merged
merged 2 commits into from
Apr 18, 2019
Merged

Update etcd3-migration.md doc #6774

merged 2 commits into from
Apr 18, 2019

Conversation

bksteiny
Copy link
Contributor

Hi folks, I mentioned in office hours today that I would update the etcd migration doc with a few things I ran into while testing the 1.12 beta.

Feel free to accept/reject the edits.

I am also curious if this line will still be valid in the etcd/manager.md documentation after kops 1.12 goes GA:

Reminder: etcd-manager is alpha, and we encourage you to back up the data in your kubernetes cluster.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 12, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @bksteiny. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 12, 2019
bksteiny
bksteiny commented Apr 12, 2019
View reviewed changes
docs/etcd3-migration.md
@@ -63,7 +80,8 @@ more disruption and are not necessarily lower risk.

### Adopt etcd-manager with kops 1.11 / kubernetes 1.11

To adopt etcd-manager before kops 1.12 & kubernetes 1.12, you
If you don't already have TLS enabled with etcd, you can adopt etcd-manager before
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put this qualifier in here because I received this error message when trying to use etcd-manager with kops 1.11.0 and 1.11.1. This could have been user error 🤷‍♂️

"error building tasks: TLS not supported for etcd-manager"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we ran into that as well.

@bksteiny
Copy link
Contributor Author

/assign @justinsb

@rifelpet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2019
@rifelpet
Copy link
Member

/area documentation

@mikesplain
Copy link
Contributor

Even though this is a doc, this should be included in the 1.12 branch. Marking as cherry-pick

@mikesplain
Copy link
Contributor

I think this includes some good additions that we should get merged in. We can change and get more comments in follow up PRs. Thanks @bksteiny!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bksteiny, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit c816337 into kubernetes:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesplain mikesplain mikesplain left review comments

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cherry-pick cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bksteiny @k8s-ci-robot @rifelpet @mikesplain @justinsb