Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos in files #6064

Merged
merged 1 commit into from
Nov 10, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/single-to-multi-master.md
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ and not during a future upgrade or, worse, during a master failure.

In case you failed to upgrade to multi-master you will need to restore from the backup you have taken previously.

Take extra care becase kops will not start etcd and etcd-events with the same ID on <master-b> an/or <master-c> for example but will mix them (ex: etcd-b and etcd-events-c on <master-b> & etcd-c and etcd-events-b on <master-c> ); this can be double checked in Route53 where kops will create DNS records for your services.
Take extra care because kops will not start etcd and etcd-events with the same ID on <master-b> an/or <master-c> for example but will mix them (ex: etcd-b and etcd-events-c on <master-b> & etcd-c and etcd-events-b on <master-c> ); this can be double checked in Route53 where kops will create DNS records for your services.

If your 2nd spinned master failed and cluster becomes inconsistent edit the corresponding kops master instancegroup and switch ``MinSize`` and ``MaxSize`` to "0" and run an update on your cluster.

Expand Down
2 changes: 1 addition & 1 deletion nodeup/pkg/model/kube_proxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func (b *KubeProxyBuilder) Build(c *fi.ModelBuilderContext) error {
return nil
}

// buildPod is responsble constructing the pod spec
// buildPod is responsible constructing the pod spec
func (b *KubeProxyBuilder) buildPod() (*v1.Pod, error) {
c := b.Cluster.Spec.KubeProxy
if c == nil {
Expand Down
2 changes: 1 addition & 1 deletion upup/pkg/fi/fitasks/mirrorsecrets.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func (e *MirrorSecrets) Find(c *fi.Context) (*MirrorSecrets, error) {
return nil, nil
}

// Run implemements fi.Task::Run
// Run implements fi.Task::Run
func (e *MirrorSecrets) Run(c *fi.Context) error {
return fi.DefaultDeltaRunMethod(e, c)
}
Expand Down