Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly install conntrack #5745

Merged
merged 1 commit into from
Sep 14, 2018
Merged

Explicitly install conntrack #5745

merged 1 commit into from
Sep 14, 2018

Conversation

johanneswuerbach
Copy link
Contributor

Fixes #5671

Explicitly install conntrack on debian and rhel distros and using a static binary on CoreOS.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 3, 2018
@johanneswuerbach
Copy link
Contributor Author

/assign @justinsb

@chrisz100
Copy link
Contributor

@johanneswuerbach please look into the travis ci job and fix formatting before we pass this on to the e2e and verify tests.

@johanneswuerbach
Copy link
Contributor Author

@chrisz100 fixed, looks like my editor auto-formatting was already using go 1.11

@chrisz100
Copy link
Contributor

/ok-to-test

Will do a proper review tomorrow when back in Germany, it’s been a day.

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 4, 2018
@chrisz100
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2018
@mikesplain
Copy link
Contributor

This looks nice, thanks so much @johanneswuerbach! I'm going to assign @geojaz since he was commenting on that issue recently.

@mikesplain
Copy link
Contributor

mikesplain commented Sep 5, 2018 •
edited
Loading

/assign @geojaz

(hit enter too soon 😢 )

@justinsb
Copy link
Member

Great idea - thank you! We should also think about installing this on ContainerOS, although I don't think GCE exhibits the DNS issue as much as AWS does, for reasons that are not entirely yet clear (to me).

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, johanneswuerbach, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit 611a343 into kubernetes:master Sep 14, 2018
@johanneswuerbach johanneswuerbach deleted the add-conntrack branch September 14, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

@chrisz100 chrisz100

@geojaz geojaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@johanneswuerbach @chrisz100 @mikesplain @justinsb @k8s-ci-robot @geojaz