-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small typo fix #5721
Small typo fix #5721
Conversation
/assign @geojaz |
Just comment changes so no way affecting functionality. Thanks @AdamDang ! /ok-to-test |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AdamDang, chrisz100 If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area documentation |
@AdamDang before we merge this, can you please complete: FAIL: make verify-gendocs failed, as the generated markdown docs are out of date.
FAIL: Please run the following command: make gen-cli-docs. |
Looks like there's a lot of overlap with #4687. The only files not covered are:
|
Going to force-merge and throw into the docs-fix PR I have for the other one where I did the same thing. Thanks for the fix @AdamDang ! |
Follow on to kubernetes#5425; another flag and we need to update the source code as well as the output. Follow on also to kubernetes#5721 and kubernetes#4687
Fix the typos :
"a ssh"->"an ssh"
"an new ssh"->"a new ssh"