Enable weave network encryption for k8s 1.6

[Andrey9kin]

No description provided.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Andrey9kin]

Trying to get CLA singed. Waiting for verification email from Linux Foundation

[Andrey9kin]

@kampka I followed your commit where you updated k8s-1.7 yaml. Could you please take a look

[Andrey9kin]

/assign @gambol99

[Andrey9kin]

/assign @kampka

[k8s-ci-robot]

@Andrey9kin: GitHub didn't allow me to assign the following users: kampka.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @kampka

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kampka]

For what its worth:

/lgtm

:)

[k8s-ci-robot]

@kampka: changing LGTM is restricted to assignees, and only kubernetes/kops repo collaborators may be assigned issues.

In response to this:

For what its worth:

/lgtm

:)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chrisz100]

/ok-to-test
/lgtm

Thanks for the contribution!

[chrisz100]

/area networking

[justinsb]

This makes sense; if the user doesn't enable weave encryption it should be a no-op, so I'd argue it's just confusing that it doesn't do anything on k8s 1.6.

I would suggest upgrading to a newer version of k8s though @Andrey9kin - we are contemplating stopping support in kops for older versions of k8s, because technically k8s itself doesn't get security patches etc. I'm not sure if you're actually running an older version of k8s or if this is just for consistency?

In any case, thank you for the PR @Andrey9kin

/approve
/lgtm

[Andrey9kin]

@justinsb we are still running 1.6.13 and planning to upgrade within in a couple of months (hopefully) but for a time being it would be great to avoid dealing with an in-house build of kops where this patch is included

[justinsb]

Didn't mean to remove approved!

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andrey9kin, chrisz100, justinsb, kampka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [justinsb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment