set max pods when using aws vpc cni #5510
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sethpollack If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/L
|
/assign @justinsb |
|
Here is the info on how to calculate MaxPods: |
|
Hey, this is great. I was just looking to increase the number of pods on my hosts. I'm running m5.4xlarges so I guess I can set it to 234 pods now and this work will eventually make that hard-coding obsolete. |
|
I could really use this. It would be nice to see the number of pods that can be launched when using the AWS CNI on the dashboard like EKS automatically. |
|
@sethpollack: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-rebase
|
Uhoh - sorry - this is going to conflict with the automatic generation that is about to merge in #5553. Can we compute the field automatically? Probably by embedding the table into go code, and then emitting it in the generator. |
| maxPods := int32(instanceType.MaxPods) | ||
| c.MaxPods = &maxPods | ||
| if b.InstanceGroup.Spec.Kubelet != nil { | ||
| if b.InstanceGroup.Spec.Kubelet.MaxPods == nil { |
There was a problem hiding this comment.
I'm also wondering if we should only set MaxPods lower, so the default is around 100 I believe. The problem is that e.g. polling all the containers is pretty slow.
OTOH I'm also open to just setting it everywhere, because it's the bigger instances anyway that allow more than 100 VPC addresses.
No description provided.