Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable conntrack settings #5456

Merged
merged 1 commit into from
Jul 19, 2018
Merged

Add configurable conntrack settings #5456

merged 1 commit into from
Jul 19, 2018

Conversation

mikesplain
Copy link
Contributor

@mikesplain mikesplain commented Jul 18, 2018 •
edited
Loading

This PR allows adjusting kube-proxy's conntrack-max-per-core and conntrack-min in clusterspec for kube-proxy.

Specifically, I need this for testing fixes for this dns issue (#5283 and kubernetes/kubernetes#45976 (comment))

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2018
@mikesplain
Copy link
Contributor Author

/assign @justinsb

I know you're about to cut a release, but is it possible to fit this in?

@justinsb
Copy link
Member

Looks good & safe, and helps to test the other issues, so I think it's worth it

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2018
@k8s-ci-robot k8s-ci-robot merged commit 0e64d32 into kubernetes:master Jul 19, 2018
@mikesplain mikesplain deleted the configurable_conntrack branch July 19, 2018 20:08
@mikesplain
Copy link
Contributor Author

Great thanks @justinsb!

azman0101 pushed a commit to azman0101/kops that referenced this pull request Jul 25, 2018
@mikesplain @JBOClara
Cherry pick of kubernetes#5456 onto release-1.9
b12c037
azman0101 pushed a commit to azman0101/kops that referenced this pull request Jul 27, 2018
@mikesplain @JBOClara
Cherry pick of kubernetes#5456 onto release-1.9
d062a8d
@zapman449
Copy link

Will there be a release of kops 1.9.2 or similar which includes this, or should something similar be built from source?

@mikesplain
Copy link
Contributor Author

@zapman449 Probably not but it will be included in 1.10 and is included in the 1.10 beta if you want to give that a shot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikesplain @justinsb @k8s-ci-robot @zapman449