-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Heptio Authenticator to AWS IAM Authenticator. #5420
Rename Heptio Authenticator to AWS IAM Authenticator. #5420
Conversation
- and "Heptio Authenticator" to "AWS IAM Authenticator.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: niclic Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @niclic. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
See also #5424 |
@niclic: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
duplicate of #5421 ? |
Okay. |
In light of the recent renaming of
Heptio Authenticator
toAWS IAM Authenticator for Kubernetes
, now might be a good time to follow suit.References:
This PR is an initial attempt at this. Tests pass but I have not yet created a cluster from a local build.
The changes so far are cosmetic and some questions remain:
Should the spec change? If so, then to what?
The
AuthenticationSpec
retains a key calledHeptio
of typeHeptioAuthenticationSpec
.What about addon resources? See 1.
The
aws-iam-authenticator
manifest(s) are in a directory calledauthentication.hept.io
.Binary has changed but no new docker image pushed as of yet.
The docker image remains:
gcr.io/heptio-images/authenticator:v0.3.0
, so the binary will still beheptio-authenticator-aws
. Updated images will likely be published very soon.Original PR: #5197