Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Heptio Authenticator to AWS IAM Authenticator. #5420

Conversation

niclic
Copy link

@niclic niclic commented Jul 8, 2018

In light of the recent renaming of Heptio Authenticator to AWS IAM Authenticator for Kubernetes, now might be a good time to follow suit.

References:

This PR is an initial attempt at this. Tests pass but I have not yet created a cluster from a local build.

The changes so far are cosmetic and some questions remain:

  1. Should the spec change? If so, then to what?
    The AuthenticationSpec retains a key called Heptio of type HeptioAuthenticationSpec.

  2. What about addon resources? See 1.
    The aws-iam-authenticator manifest(s) are in a directory called authentication.hept.io.

  3. Binary has changed but no new docker image pushed as of yet.
    The docker image remains: gcr.io/heptio-images/authenticator:v0.3.0, so the binary will still be heptio-authenticator-aws. Updated images will likely be published very soon.

Original PR: #5197

  - and "Heptio Authenticator" to "AWS IAM Authenticator.
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: niclic
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: chrislovecnm

Assign the PR to them by writing /assign @chrislovecnm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @niclic. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 8, 2018
@niclic
Copy link
Author

niclic commented Jul 10, 2018

See also #5424

@niclic niclic changed the title WIP: Rename Heptio Authenticator to AWS IAM Authenticator. Rename Heptio Authenticator to AWS IAM Authenticator. Jul 10, 2018
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 10, 2018
@k8s-ci-robot
Copy link
Contributor

@niclic: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rifelpet
Copy link
Member

duplicate of #5421 ?

@niclic
Copy link
Author

niclic commented Jul 11, 2018

Okay.

@niclic niclic closed this Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants