-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup heptio authenticator #5197
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -157,6 +157,105 @@ func (b *KubeAPIServerBuilder) writeAuthenticationConfig(c *fi.ModelBuilderConte | |
return nil | ||
} | ||
|
||
if b.Cluster.Spec.Authentication.Heptio != nil { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps left to another PR, but should consider merging the kopeio and this together given both is essentially just a web hook with a url diff .. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will create another PR to merge / cleanup. |
||
id := "heptio-authenticator-aws" | ||
b.Cluster.Spec.KubeAPIServer.AuthenticationTokenWebhookConfigFile = fi.String(PathAuthnConfig) | ||
|
||
{ | ||
caCertificate, err := b.NodeupModelContext.KeyStore.FindCert(fi.CertificateId_CA) | ||
if err != nil { | ||
return fmt.Errorf("error fetching Heptio Authentication CA certificate from keystore: %v", err) | ||
} | ||
if caCertificate == nil { | ||
return fmt.Errorf("Heptio Authentication CA certificate %q not found", fi.CertificateId_CA) | ||
} | ||
|
||
cluster := kubeconfig.KubectlCluster{ | ||
Server: "https://127.0.0.1:21362/authenticate", | ||
} | ||
context := kubeconfig.KubectlContext{ | ||
Cluster: "heptio-authenticator-aws", | ||
User: "kube-apiserver", | ||
} | ||
|
||
cluster.CertificateAuthorityData, err = caCertificate.AsBytes() | ||
if err != nil { | ||
return fmt.Errorf("error encoding Heptio Authentication CA certificate: %v", err) | ||
} | ||
|
||
config := kubeconfig.KubectlConfig{} | ||
config.Clusters = append(config.Clusters, &kubeconfig.KubectlClusterWithName{ | ||
Name: "heptio-authenticator-aws", | ||
Cluster: cluster, | ||
}) | ||
config.Users = append(config.Users, &kubeconfig.KubectlUserWithName{ | ||
Name: "kube-apiserver", | ||
}) | ||
config.CurrentContext = "webhook" | ||
config.Contexts = append(config.Contexts, &kubeconfig.KubectlContextWithName{ | ||
Name: "webhook", | ||
Context: context, | ||
}) | ||
|
||
manifest, err := kops.ToRawYaml(config) | ||
if err != nil { | ||
return fmt.Errorf("error marshalling authentication config to yaml: %v", err) | ||
} | ||
|
||
c.AddTask(&nodetasks.File{ | ||
Path: PathAuthnConfig, | ||
Contents: fi.NewBytesResource(manifest), | ||
Type: nodetasks.FileType_File, | ||
Mode: fi.String("600"), | ||
}) | ||
} | ||
|
||
{ | ||
certificate, err := b.NodeupModelContext.KeyStore.FindCert(id) | ||
if err != nil { | ||
return fmt.Errorf("error fetching %q certificate from keystore: %v", id, err) | ||
} | ||
if certificate == nil { | ||
return fmt.Errorf("certificate %q not found", id) | ||
} | ||
|
||
certificateData, err := certificate.AsBytes() | ||
if err != nil { | ||
return fmt.Errorf("error encoding %q certificate: %v", id, err) | ||
} | ||
|
||
c.AddTask(&nodetasks.File{ | ||
Path: "/srv/kubernetes/heptio-authenticator-aws/cert.pem", | ||
Contents: fi.NewBytesResource(certificateData), | ||
Type: nodetasks.FileType_File, | ||
Mode: fi.String("600"), | ||
}) | ||
} | ||
|
||
{ | ||
privateKey, err := b.NodeupModelContext.KeyStore.FindPrivateKey(id) | ||
if err != nil { | ||
return fmt.Errorf("error fetching %q private key from keystore: %v", id, err) | ||
} | ||
if privateKey == nil { | ||
return fmt.Errorf("private key %q not found", id) | ||
} | ||
|
||
keyData, err := privateKey.AsBytes() | ||
if err != nil { | ||
return fmt.Errorf("error encoding %q private key: %v", id, err) | ||
} | ||
|
||
c.AddTask(&nodetasks.File{ | ||
Path: "/srv/kubernetes/heptio-authenticator-aws/key.pem", | ||
Contents: fi.NewBytesResource(keyData), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add file perms to 0600 please There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are the perms that I think are still missing @rdrgmnzs There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think you added it to this task (key.pem( - I do see it for the other two file tasks though. |
||
Type: nodetasks.FileType_File, | ||
}) | ||
} | ||
|
||
return nil | ||
} | ||
|
||
return fmt.Errorf("Unrecognized authentication config %v", b.Cluster.Spec.Authentication) | ||
} | ||
|
||
|
@@ -311,7 +410,7 @@ func (b *KubeAPIServerBuilder) buildPod() (*v1.Pod, error) { | |
} | ||
|
||
if b.Cluster.Spec.Authentication != nil { | ||
if b.Cluster.Spec.Authentication.Kopeio != nil { | ||
if b.Cluster.Spec.Authentication.Kopeio != nil || b.Cluster.Spec.Authentication.Heptio != nil { | ||
addHostPathMapping(pod, container, "authn-config", PathAuthnConfig) | ||
} | ||
} | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happen's if the config isn't there? .. does it's just crashloop the pods? ... Just wondering in case it effects rollouts .. i'm pretty sure the validate cluster code looks for pod restarts in kube-system ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pod will sit in a
creating
status. I have not tired doing a rollout while it's in this state, but will do so.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ar yes! .. it would be stuck in pending .. Still if you can quickly verify / confirm it handles on a pre-built cluster and can rollout, that would be cool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pod stays in state:
kube-system heptio-authenticator-aws-4fkzp 0/1 ContainerCreating 0 10m
with the error:
Unable to mount volumes for pod "heptio-authenticator-aws-4fkzp_kube-system(93f46fcb-654e-11e8-a014-0e21d0512306)": timeout expired waiting for volumes to attach or mount for pod "kube-system"/"heptio-authenticator-aws-4fkzp". list of unmounted volumes=[config]. list of unattached volumes=[config output state default-token-6rtmz]
However I'm still able to perform a full cluster rolling update while the cluster is in this state so we should be ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much appreciated 👍