-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix broken link to example policy file in the cluster_spec docs #5146
Conversation
Thanks for the fix @kaspernissen! Much appreciated! /ok-to-test |
Sure thing, happy to help. /assign @KashifSaadat |
Thanks @kaspernissen 👍 /approve |
Going to try closing & reopening in the hope of waking up CLA bot |
/approve /lgtm (trying one more time and then will ask the clabot maintainers..) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, KashifSaadat, kaspernissen, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/check-cla Maybe that'll do it :-) |
It's hard to get a one-line doc PR merged 😆 hope it succeeds this time! Thank you for the effort, Justin. |
Aha! @kaspernissen you don't have an email in your commit. It literally says I think you need to do this, and then amend the commit. Probably something like this:
|
(And the email needs to be the one you're signing the CLA with) |
New changes are detected. LGTM label has been removed. |
@justinsb sorry for the rookie mistake. Should be fixed now. 🙂 |
Thanks @kaspernissen :) Will kick off a retest to see if the Travis CI failure has been fixed. /retest |
Fixed the Travis CI test failure in PR #5301. If/once merged, you may have to rebase off master with the fix I'm afraid.
|
Actually I can just force-merge this one - it isn't an issue with this PR (but thank you @KashifSaadat !). Thanks for all the persistence @kaspernissen ! |
Aha perfect, thanks! :) |
The link in the cluster_spec docs was broken directing to a page no longer existing.
Corrected this to the link of the example currently displayed at: https://kubernetes.io/docs/tasks/debug-application-cluster/audit/