Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken link to example policy file in the cluster_spec docs #5146

Merged
merged 1 commit into from
Jun 11, 2018
Merged

fix broken link to example policy file in the cluster_spec docs #5146

merged 1 commit into from
Jun 11, 2018

Conversation

kaspernissen
Copy link
Contributor

The link in the cluster_spec docs was broken directing to a page no longer existing.

Corrected this to the link of the example currently displayed at: https://kubernetes.io/docs/tasks/debug-application-cluster/audit/

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2018
@mikesplain
Copy link
Contributor

Thanks for the fix @kaspernissen! Much appreciated!

/ok-to-test
/area documentation
/lgtm

@k8s-ci-robot k8s-ci-robot added area/documentation lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 11, 2018
@kaspernissen
Copy link
Contributor Author

Sure thing, happy to help.

/assign @KashifSaadat

@KashifSaadat
Copy link
Contributor

Thanks @kaspernissen 👍

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2018
@justinsb
Copy link
Member

Going to try closing & reopening in the hope of waking up CLA bot

@justinsb justinsb closed this May 26, 2018
@justinsb justinsb reopened this May 26, 2018
@justinsb
Copy link
Member

justinsb commented Jun 1, 2018

/approve

/lgtm

(trying one more time and then will ask the clabot maintainers..)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, KashifSaadat, kaspernissen, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KashifSaadat,justinsb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb justinsb added this to the 1.10 milestone Jun 2, 2018
@justinsb
Copy link
Member

justinsb commented Jun 8, 2018

/check-cla

Maybe that'll do it :-)

@kaspernissen
Copy link
Contributor Author

It's hard to get a one-line doc PR merged 😆 hope it succeeds this time! Thank you for the effort, Justin.

@justinsb
Copy link
Member

Aha! @kaspernissen you don't have an email in your commit.

It literally says
Author: Kasper Nissen <>

I think you need to do this, and then amend the commit.

Probably something like this:

git config --global user.email "[email protected]"
git commit --amend --reset-author
git push --force

@justinsb
Copy link
Member

(And the email needs to be the one you're signing the CLA with)

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 11, 2018
@kaspernissen
Copy link
Contributor Author

@justinsb sorry for the rookie mistake. Should be fixed now. 🙂

@KashifSaadat
Copy link
Contributor

Thanks @kaspernissen :) Will kick off a retest to see if the Travis CI failure has been fixed.

/retest

@KashifSaadat
Copy link
Contributor

KashifSaadat commented Jun 11, 2018

Fixed the Travis CI test failure in PR #5301. If/once merged, you may have to rebase off master with the fix I'm afraid.

  • @kaspernissen the test failure is now fixed in master, please could you rebase your PR off of master (update master branch locally, git rebase master, and force push your branch up). Sorry about the hassle!

@justinsb
Copy link
Member

Actually I can just force-merge this one - it isn't an issue with this PR (but thank you @KashifSaadat !).

Thanks for all the persistence @kaspernissen !

@justinsb justinsb merged commit e05dbb3 into kubernetes:master Jun 11, 2018
@KashifSaadat
Copy link
Contributor

Aha perfect, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants