-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to use ec2 nat instance as egress #5133
Add ability to use ec2 nat instance as egress #5133
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @justinsb |
This is awesome :-) So I was wondering if we should build an instance object vs just changing the Route.Instance field to an string (it seems to currently be unused), but I like what you've done. One gotcha is that currently the Instance will be tagged I believe; we probably don't want to do that when we specify it by ID (I think it's more likely to get deleted for example). I'll send a PR to change Instance to take a list of Tags, which is the way we've settled on doing this now :-) /approve /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, relu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Hello folks, I bumped into the of lack of support for NAT instances as egress and here's what I came up with to help support it. I'm not sure if this is the right approach, even though the solution worked in my test case.
Mind you, this is my first time working with golang so please bear with me. I'd be more than happy to help out move this forward with a bit of guidance.
This relates to #1530.