-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate live project documentation using mkdocs and gh-pages #5085
Conversation
4697332
to
883b1cf
Compare
/assign @justinsb |
@justinsb ping |
Yes we can move it, but we need to fix apireference already. What is the purpose of this PR btw? I know what it does, but in the big picture what value are we getting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, and appreciate the work, but our goal has been to get our docs on kubernetes.io. I do not think other k8s projects are maintaining gh-pages. Thoughts?
|
||
.PHONY: live-docs | ||
live-docs: | ||
@docker run --rm -it -p 3000:3000 -v ${PWD}:/docs aledbf/mkdocs:0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aledbf/mkdocs:0.1
I am not a huge fan of pulling in external containers. I know you are maintaining this, but any other options?
|
||
| kops version | k8s 1.5.x | k8s 1.6.x | k8s 1.7.x | k8s 1.8.x | k8s 1.9.x | | ||
|--------------|-----------|-----------|-----------|-----------|-----------| | ||
| 1.9.x | Y | Y | Y | Y | Y | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need 1.10 included
|
||
git add . | ||
git commit -m "Deploy GitHub Pages" | ||
git push --force --quiet "https://${GH_TOKEN}@${GH_REF}" gh-pages > /dev/null 2>&1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we looking at gh-pages? We really need our docs on kubernetes.io :shrug
Who's working on that?
I think the goal should be provide a better UX for user documentation, including search.
I already do this https://kubernetes.github.io/ingress-nginx/ |
@chrislovecnm I can close this PR if the goal is to get the docs on kubernetes.io |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aledbf If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is awesome, thank you @aledbf . We'll have to reorg our docs a little, but I think people want to do that anyway. I'm going to go ahead and merge this so we can get the reorg started :-) |
Note: to build I need to remove
docs/apireference
directory. Can we move that directory?Local test:
Create a detached branch:
After this step it is possible to build and publish the docs running: